Skip to content

fix: dropdown contrast focus styles#14017

Merged
andreancardona merged 42 commits into
carbon-design-system:mainfrom
andreancardona:12720-dropdown-contrast
Jun 28, 2023
Merged

fix: dropdown contrast focus styles#14017
andreancardona merged 42 commits into
carbon-design-system:mainfrom
andreancardona:12720-dropdown-contrast

Conversation

@andreancardona

@andreancardona andreancardona commented Jun 15, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #12720

Paired up with @francinelucca - got a good solution going 🎉

Screenshot 2023-06-15 at 17 10 07

Testing / Reviewing

  • This must be tested with keyboard navigation
  • Make sure Dropdown, Combox & Multiselect have the above focus styling and the light-grey background has been removed - through all the different variants
  • Hover styles should remain the same on mouse
  • @kingtraceyj tagging you for a visual review :)

andreancardona and others added 30 commits March 31, 2023 10:43
@andreancardona
feat: contained list persistent search
1bcb232
@andreancardona
Merge branch 'main' into contained-list-persistent-search-3
b4c59bd
@andreancardona
docs: update docs for contained list search
2fe97f6
@andreancardona
fix: fix border
b69b5bd
@andreancardona
feat: functionality working
d09b917
@alisonjoseph
fix(tabs): hover style bugs
763283f
@alisonjoseph
fix: remove hover from disabled state
665bed4
@andreancardona
feat: clean up code
ce07f2a
@andreancardona @francinelucca
Update packages/react/src/components/ContainedList/ContainedList.mdx
a224005 
Co-authored-by: Francine Lucca <40550942+francinelucca@users.noreply.github.com>
@andreancardona
fix: update docs
aa8947e
@andreancardona
Merge branch 'contained-list-persistent-search-3' of github.com:andre…
28b000c 
…ancardona/carbon into contained-list-persistent-search-3
@andreancardona @francinelucca
fix: fix styling
a9f8b8b 
Co-authored-by: Francine Lucca <francinelucca@users.noreply.github.com>
@andreancardona
fix: update docs
814cc3b
@andreancardona
Merge branch 'main' into contained-list-persistent-search-3
b45a5bf
@andreancardona
Merge branch 'main' into contained-list-persistent-search-3
0b8b9f9
@andreancardona
Merge branch 'main' into 13490-tab-hover-bug
f63a300
@kodiakhq
Merge branch 'main' into 13490-tab-hover-bug
6757739
@andreancardona
Merge branch '13490-tab-hover-bug' of github.com:alisonjoseph/carbon;…
231d315 
… branch 'contained-list-persistent-search-3' of github.com:andreancardona/carbon into contained-list-persistent-search-3
@andreancardona
Merge branch 'main' into contained-list-persistent-search-3
d91e70d
@andreancardona
fix: failing test
b759ac5
@andreancardona
Merge branch 'main' into contained-list-persistent-search-3
b214fd6
@andreancardona
fix: fix tests
686a43f
@andreancardona
Merge branch 'andreancardona-contained-list-persistent-search-3'
cce6839
@andreancardona
Merge branch 'main' of github.com:carbon-design-system/carbon
5e959a5
@andreancardona
Merge branch 'main' of github.com:carbon-design-system/carbon
1a6d1c1
@andreancardona
Merge branch 'main' of github.com:carbon-design-system/carbon
6607284
@andreancardona
Merge branch 'main' of github.com:carbon-design-system/carbon
64172da
@andreancardona
Merge branch 'main' of github.com:carbon-design-system/carbon
8fb6526
@andreancardona
Merge branch 'main' of github.com:carbon-design-system/carbon
5abf03d
@andreancardona
Merge branch 'main' of github.com:carbon-design-system/carbon
4841276
@andreancardona andreancardona marked this pull request as ready for review June 20, 2023 21:49
kingtraceyj
kingtraceyj approved these changes Jun 22, 2023
View reviewed changes

@kingtraceyj kingtraceyj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

focus styles match spec. looks good to go! 💥

guidari
guidari approved these changes Jun 22, 2023
View reviewed changes

@guidari guidari left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I just added a aria-owns in the ComboBox.tsx because when we turn on the VO in FireFox it closes the ComboBox when the user tries to navigate.
Let me know if that make sense

@andreancardona

andreancardona commented Jun 27, 2023

Copy link
Copy Markdown
Contributor Author

Trying to see the best way to fix the failing avt test

@guidari

guidari commented Jun 27, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Trying to see the best way to fix the failing avt test

Is this related to the aria-owns that was added @andreancardona ? Looks like the tests broke after that addition
I'll take a look to help fix it

@andreancardona

andreancardona commented Jun 27, 2023

Copy link
Copy Markdown
Contributor Author

Trying to see the best way to fix the failing avt test

Is this related to the aria-owns that was added @andreancardona ? Looks like the tests broke after that addition I'll take a look to help fix it

yep it is related - just trying to find a solution for both the test and the FF bug

@andreancardona andreancardona merged commit a460b28 into carbon-design-system:main Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

@kingtraceyj kingtraceyj kingtraceyj approved these changes

@alisonjoseph alisonjoseph Awaiting requested review from alisonjoseph alisonjoseph was automatically assigned from carbon-design-system/developers-system

+1 more reviewer

@guidari guidari guidari approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component: combobox component: dropdown component: multiselect status: ready to merge 🎉 type: a11y ♿

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[a11y]: Dropdown component contrast for item with focus/selection fails

7 participants

@andreancardona @guidari @tay1orjones @kingtraceyj @alisonjoseph @francinelucca @tw15egan