Skip to content

chore(package): remove sketch#14010

Merged
kodiakhq[bot] merged 6 commits into
carbon-design-system:mainfrom
falsepopsky:remove/package-sketch
Jun 20, 2023
Merged

chore(package): remove sketch#14010
kodiakhq[bot] merged 6 commits into
carbon-design-system:mainfrom
falsepopsky:remove/package-sketch

Conversation

@falsepopsky

@falsepopsky falsepopsky commented Jun 15, 2023

Copy link
Copy Markdown
Contributor

Closes #13863

Changelog

Removed

  • package sketch

Testing / Reviewing

{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

@falsepopsky falsepopsky requested a review from a team as a code owner June 15, 2023 18:35
@netlify

netlify Bot commented Jun 15, 2023

Copy link
Copy Markdown

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a485831
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/6491fb2d4df66b00089e60e0
😎 Deploy Preview https://deploy-preview-14010--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify

netlify Bot commented Jun 15, 2023

Copy link
Copy Markdown

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit a485831
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6491fb2dbecf5f0008e2af42
😎 Deploy Preview https://deploy-preview-14010--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Comment thread .github/workflows/v10-release.yml
@falsepopsky falsepopsky changed the title chore(remove): package sketch chore(package): remove sketch Jun 16, 2023
Comment thread .github/workflows/v10-ci.yml

@guidari guidari left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I was about to work on this issue. Thank you for resolving it!

@francinelucca

Copy link
Copy Markdown
Contributor

@falsepopsky this should be ready to merge once the merge conflicts have been resolved 🙏🏻

@falsepopsky falsepopsky force-pushed the remove/package-sketch branch from 6f0e84f to 0c7a86e Compare June 20, 2023 19:11
@kodiakhq kodiakhq Bot merged commit fd00277 into carbon-design-system:main Jun 20, 2023
@falsepopsky falsepopsky deleted the remove/package-sketch branch July 10, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the sketch plugin from the codebase

4 participants