Skip to content

fix(ToggleSkeleton): fix issue with ToggleSkeleton style#13963

Merged
andreancardona merged 11 commits into
carbon-design-system:mainfrom
modaslam:bugfix/toggleskeleton-broken-visual
Jun 19, 2023
Merged

fix(ToggleSkeleton): fix issue with ToggleSkeleton style#13963
andreancardona merged 11 commits into
carbon-design-system:mainfrom
modaslam:bugfix/toggleskeleton-broken-visual

Conversation

@modaslam

@modaslam modaslam commented Jun 10, 2023

Copy link
Copy Markdown
Contributor

Closes #13459 and #13485

Fixed broken visuals of ToggleSkeleton component and added a story for it

Changelog

New

  • Added story for ToggleSkeleton component inside Toggle folder

Changed

  • Fixed broken visuals of ToggleSkeleton according to design specification

Removed

  • Removed code for outdated ToggleSkeleton design

Testing / Reviewing

Go to the story in Toggle folder and ensure the Skeleton is displayed correctly according to design spec shown in #13485.

@modaslam modaslam requested review from a team as code owners June 10, 2023 04:51
@github-actions

github-actions Bot commented Jun 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

DCO Assistant Lite bot All contributors have signed the DCO.

@netlify

netlify Bot commented Jun 10, 2023 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 50e113e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/6490c087b0663700086718e8
😎 Deploy Preview https://deploy-preview-13963--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify

netlify Bot commented Jun 10, 2023 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 50e113e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6490c0876e44a70008bbb0d6
😎 Deploy Preview https://deploy-preview-13963--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@modaslam
fix(ToggleSkeleton): fix issue with ToggleSkeleton style
ea52955 
Signed-off-by: Mohammed Aslam P. A <Mohammed.Aslam.P.A@ibm.com>
@modaslam modaslam force-pushed the bugfix/toggleskeleton-broken-visual branch from 0be906a to ea52955 Compare June 11, 2023 08:39
@modaslam

modaslam commented Jun 11, 2023

Copy link
Copy Markdown
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@francinelucca francinelucca requested review from a team and kingtraceyj and removed request for a team June 12, 2023 21:07
@francinelucca francinelucca requested a review from thyhmdo June 12, 2023 21:07
francinelucca
francinelucca suggested changes Jun 12, 2023
View reviewed changes

@francinelucca francinelucca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking pretty good, have some observations and looks like there are some merge conflicts @modaslam

Also wondering if just the rectangle needs to be animated or also th

toggle.mov

e circle? @thyhmdo

Comment thread packages/react/src/components/Toggle/Toggle.stories.js
Comment thread packages/styles/scss/components/toggle/_toggle.scss Outdated
@modaslam

modaslam commented Jun 13, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This is looking pretty good, have some observations and looks like there are some merge conflicts @modaslam

Also wondering if just the rectangle needs to be animated or also th

toggle.mov
e circle? @thyhmdo

I have added a similar animation for the circle as well if you need to check and also resolved the merge conflicts. @francinelucca

@francinelucca francinelucca self-requested a review June 13, 2023 23:08
francinelucca
francinelucca suggested changes Jun 14, 2023
View reviewed changes
Comment thread packages/styles/scss/utilities/_skeleton.scss Outdated
francinelucca
francinelucca approved these changes Jun 14, 2023
View reviewed changes

@francinelucca francinelucca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending visual review

kingtraceyj
kingtraceyj approved these changes Jun 16, 2023
View reviewed changes

@kingtraceyj kingtraceyj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the revision matches design spec—good to go! 💥

andreancardona
andreancardona approved these changes Jun 19, 2023
View reviewed changes

@andreancardona andreancardona left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎 @modaslam thank you so much for the contribution 🎉

@andreancardona andreancardona enabled auto-merge (squash) June 19, 2023 20:54
@andreancardona andreancardona merged commit 7de2ef3 into carbon-design-system:main Jun 19, 2023
@modaslam modaslam deleted the bugfix/toggleskeleton-broken-visual branch June 20, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kingtraceyj kingtraceyj kingtraceyj approved these changes

@thyhmdo thyhmdo Awaiting requested review from thyhmdo

+2 more reviewers

@andreancardona andreancardona andreancardona approved these changes

@francinelucca francinelucca francinelucca approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: ready to merge 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ToggleSkeleton: Broken Visuals

4 participants

@modaslam @kingtraceyj @andreancardona @francinelucca