Skip to content

test(react): update Form components' tests to RTL#11691

Merged
kodiakhq[bot] merged 6 commits into
carbon-design-system:mainfrom
abbeyhrt:test/form-test
Jul 5, 2022
Merged

test(react): update Form components' tests to RTL#11691
kodiakhq[bot] merged 6 commits into
carbon-design-system:mainfrom
abbeyhrt:test/form-test

Conversation

@abbeyhrt

Copy link
Copy Markdown
Contributor

Closes #11644
Closes #11643
Closes #11642
Closes #11641

Updates tests to RTL for Form, FormGroup, FormLabel, and FormItem. Those components don't have much behavior to them (if any as far as I could tell) so the tests verify that the props are working as expected.

@abbeyhrt abbeyhrt requested a review from a team as a code owner June 27, 2022 20:30
@abbeyhrt abbeyhrt requested review from tay1orjones and tw15egan June 27, 2022 20:30
@netlify

netlify Bot commented Jun 27, 2022

Copy link
Copy Markdown

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit dd3ea12
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/62ba13715ab5080007d36276
😎 Deploy Preview https://deploy-preview-11691--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify

netlify Bot commented Jun 27, 2022

Copy link
Copy Markdown

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit dd3ea12
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/62ba1371e1e24f0009ed461e
😎 Deploy Preview https://deploy-preview-11691--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify

netlify Bot commented Jun 27, 2022

Copy link
Copy Markdown

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ebca1b4
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/62c48582182f0e0008375fe3
😎 Deploy Preview https://deploy-preview-11691--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify

netlify Bot commented Jun 27, 2022

Copy link
Copy Markdown

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit ebca1b4
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/62c4858228d0ad0009643584
😎 Deploy Preview https://deploy-preview-11691--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tay1orjones tay1orjones left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Comment thread packages/react/src/components/FormLabel/FormLabel-test.js Outdated
abbeyhrt and others added 2 commits June 28, 2022 11:03

@tw15egan tw15egan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@kodiakhq kodiakhq Bot merged commit c095635 into carbon-design-system:main Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

3 participants