Skip to content

chore(TimePicker): updated size prop for v11#10944

Merged
sstrubberg merged 3 commits into
carbon-design-system:mainfrom
sstrubberg:timepicker-size-audit
Mar 15, 2022
Merged

chore(TimePicker): updated size prop for v11#10944
sstrubberg merged 3 commits into
carbon-design-system:mainfrom
sstrubberg:timepicker-size-audit

Conversation

@sstrubberg

@sstrubberg sstrubberg commented Mar 9, 2022

Copy link
Copy Markdown
Member

REF #10295

  • Modified the size prop to only accept SM, MD, LG.
  • Added md as a default for the size prop.
  • Added Controls functionality to Storybook story.
  • Removed xl size from styles.

Testing

  • Make sure everything is snappy in the v11 Storybook. Size controls should allow for SM, MD, and LG

@sstrubberg sstrubberg requested a review from a team as a code owner March 9, 2022 16:20
@netlify

netlify Bot commented Mar 9, 2022 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 12e2271

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6230b8a42b847a000835a107

😎 Browse the preview: https://deploy-preview-10944--carbon-react-next.netlify.app

@netlify

netlify Bot commented Mar 9, 2022 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 12e2271

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6230b8a4f41c5500096d2939

😎 Browse the preview: https://deploy-preview-10944--carbon-elements.netlify.app

@netlify

netlify Bot commented Mar 9, 2022 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 12e2271

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6230b8a42ff9cb00091926c4

😎 Browse the preview: https://deploy-preview-10944--carbon-components-react.netlify.app

@sstrubberg sstrubberg enabled auto-merge (squash) March 15, 2022 16:02
@sstrubberg sstrubberg merged commit ee251fd into carbon-design-system:main Mar 15, 2022
@sstrubberg sstrubberg deleted the timepicker-size-audit branch March 16, 2022 15:47
@sstrubberg sstrubberg mentioned this pull request Mar 17, 2022
Closed
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

+1 more reviewer

@aledavila aledavila aledavila approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sstrubberg @tay1orjones @aledavila