Skip to content

fix(styles): v11 OverflowMenu audit changes#10942

Merged
kodiakhq[bot] merged 3 commits into
carbon-design-system:mainfrom
jnm2377:overflow-menu-audit
Mar 11, 2022
Merged

fix(styles): v11 OverflowMenu audit changes#10942
kodiakhq[bot] merged 3 commits into
carbon-design-system:mainfrom
jnm2377:overflow-menu-audit

Conversation

@jnm2377

@jnm2377 jnm2377 commented Mar 8, 2022

Copy link
Copy Markdown
Contributor

Closes #10424

Changelog

Testing / Reviewing

  • Ensure v11 OverflowMenu looks as expected
  • Ensure tests pass

@jnm2377 jnm2377 requested a review from laurenmrice March 8, 2022 22:23
@jnm2377 jnm2377 requested a review from a team as a code owner March 8, 2022 22:23
@jnm2377 jnm2377 requested review from aledavila and tay1orjones March 8, 2022 22:23
@netlify

netlify Bot commented Mar 8, 2022

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 3c70306

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/622b81f9c8f0de000905aef9

😎 Browse the preview: https://deploy-preview-10942--carbon-react-next.netlify.app

@netlify

netlify Bot commented Mar 8, 2022

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 3c70306

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/622b81f941c34f0008884029

😎 Browse the preview: https://deploy-preview-10942--carbon-elements.netlify.app

@netlify

netlify Bot commented Mar 8, 2022

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 3c70306

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/622b81f9aa452e0008bcb56e

😎 Browse the preview: https://deploy-preview-10942--carbon-components-react.netlify.app

@laurenmrice laurenmrice left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still not seeing the props for Flipped (flipped) and Menu direction (direction) in the react storybook. Is this being solved in a different PR? @jnm2377

@jnm2377

jnm2377 commented Mar 9, 2022

Copy link
Copy Markdown
Contributor Author

I am still not seeing the props for Flipped (flipped) and Menu direction (direction) in the react storybook. Is this being solved in a different PR? @jnm2377

@laurenmrice see #10424 (comment) and #10424 (comment)

@laurenmrice laurenmrice left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jnm2377 Oh, thank you! Didn't scroll down all the way :). Looks good !

@abbeyhrt abbeyhrt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kodiakhq kodiakhq Bot merged commit deb2f18 into carbon-design-system:main Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Overflow-menu: v11 audit

4 participants