Skip to content

fix(styles): assign relative position to expandable tile#10064

Merged
sstrubberg merged 1 commit into
carbon-design-system:mainfrom
metonym:fix-tile-expandable
Nov 8, 2021
Merged

fix(styles): assign relative position to expandable tile#10064
sstrubberg merged 1 commit into
carbon-design-system:mainfrom
metonym:fix-tile-expandable

Conversation

@metonym

@metonym metonym commented Nov 6, 2021

Copy link
Copy Markdown
Collaborator

Closes #10063

This PR assigns a relative position to the bx--tile-expandable selector.

Changelog

New

  • add position: relative to .bx--tile-expandable

@metonym metonym requested a review from a team as a code owner November 6, 2021 19:22
@netlify

netlify Bot commented Nov 6, 2021

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 0dbe2a3

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6186d5e3c31ad7000857ff1b

😎 Browse the preview: https://deploy-preview-10064--carbon-react-next.netlify.app

@netlify

netlify Bot commented Nov 6, 2021

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 0dbe2a3

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6186d5e3b07d5600079fbb61

😎 Browse the preview: https://deploy-preview-10064--carbon-elements.netlify.app

@netlify

netlify Bot commented Nov 6, 2021

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 0dbe2a3

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6186d5e33636a10008525faa

😎 Browse the preview: https://deploy-preview-10064--carbon-components-react.netlify.app

@sstrubberg

Copy link
Copy Markdown
Member

@metonym This all looks great. Thanks for submitting the PR. After reviewing your changes and examining your codesandbox this seems like a slam dunk, however, I was curious why this issue isn't effecting our current storybook entry for ExpandableTile, as your codesandbox and our story are virtually the same. Any thoughts?

@abbeyhrt

abbeyhrt commented Nov 8, 2021

Copy link
Copy Markdown
Contributor

@sstrubberg I think it's because storybook automatically adds a div around ExpandableTile that has position relative on it, bounding the chevron to the tile in the story. I get why it does that but it does make bugs like this easy to miss on our end.

@sstrubberg sstrubberg merged commit 80ee23c into carbon-design-system:main Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: ExpandableTile chevron is unbounded

3 participants