fix(styles): assign relative position to expandable tile#10064
Conversation
|
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 0dbe2a3 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6186d5e3c31ad7000857ff1b 😎 Browse the preview: https://deploy-preview-10064--carbon-react-next.netlify.app |
|
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 0dbe2a3 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6186d5e3b07d5600079fbb61 😎 Browse the preview: https://deploy-preview-10064--carbon-elements.netlify.app |
|
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 0dbe2a3 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6186d5e33636a10008525faa 😎 Browse the preview: https://deploy-preview-10064--carbon-components-react.netlify.app |
|
@metonym This all looks great. Thanks for submitting the PR. After reviewing your changes and examining your codesandbox this seems like a slam dunk, however, I was curious why this issue isn't effecting our current storybook entry for ExpandableTile, as your codesandbox and our story are virtually the same. Any thoughts? |
|
@sstrubberg I think it's because storybook automatically adds a div around ExpandableTile that has position relative on it, bounding the chevron to the tile in the story. I get why it does that but it does make bugs like this easy to miss on our end. |
Closes #10063
This PR assigns a relative position to the
bx--tile-expandableselector.Changelog
New
position: relativeto.bx--tile-expandable