Skip to content

fix(components): update number input styles for focus and hover#10043

Merged
kodiakhq[bot] merged 3 commits into
carbon-design-system:mainfrom
joshblack:9859-number-input-regression
Nov 4, 2021
Merged

fix(components): update number input styles for focus and hover#10043
kodiakhq[bot] merged 3 commits into
carbon-design-system:mainfrom
joshblack:9859-number-input-regression

Conversation

@joshblack

@joshblack joshblack commented Nov 3, 2021

Copy link
Copy Markdown
Contributor

Closes #9858

Update the styles for number input to address the conflict between hover and focus in light mode.

Changelog

New

Changed

  • Update styles for number input to address a conflict with hover and focus in light mode

Removed

Testing / Reviewing

  • Pull down the PR
  • Start the storybook in packages/react
  • Visit the NumberInput story and change the Default story to use the light prop
  • Hover the number input buttons and verify that the hover color is being applied
  • Click or focus the number input buttons and verify that the outline is correctly showing around each control

@joshblack joshblack requested a review from a team as a code owner November 3, 2021 15:49
@netlify

netlify Bot commented Nov 3, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: d9e21e2

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61841d07e15dbb000895dd57

😎 Browse the preview: https://deploy-preview-10043--carbon-react-next.netlify.app

@netlify

netlify Bot commented Nov 3, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: d9e21e2

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61841d0722e9970008927e69

😎 Browse the preview: https://deploy-preview-10043--carbon-elements.netlify.app

@netlify

netlify Bot commented Nov 3, 2021 •
edited
Loading

Copy link
Copy Markdown

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: d9e21e2

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61841d07be0307000804a335

😎 Browse the preview: https://deploy-preview-10043--carbon-components-react.netlify.app

@kodiakhq kodiakhq Bot merged commit b0a79ab into carbon-design-system:main Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sstrubberg sstrubberg sstrubberg approved these changes

+1 more reviewer

@abbeyhrt abbeyhrt abbeyhrt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: ready to merge 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NumberInput Regression: different button hover CSS for light option enabled and disabled

3 participants

@joshblack @sstrubberg @abbeyhrt