fix: address misc todos (#22012)

adamalston · web-flow · commit 39eca8ace901 · 2026-04-14T06:58:02.000Z
diff --git a/packages/react/src/components/AISkeleton/AISkeletonPlaceholder.tsx b/packages/react/src/components/AISkeleton/AISkeletonPlaceholder.tsx
@@ -23,17 +23,9 @@ const AISkeletonPlaceholder = ({
   ...other
 }: AISkeletonPlaceholderProps) => {
   const prefix = usePrefix();
-  // TODO: Fix the `classnames` call. It adds a literal `className` class when
-  // `className` is truthy.
-  /*
   const AISkeletonPlaceholderClasses = classNames(className, {
     [`${prefix}--skeleton__placeholder--ai`]: true,
   });
-  */
-  const AISkeletonPlaceholderClasses = classNames(
-    { className, [`${prefix}--skeleton__placeholder--ai`]: true },
-    className
-  );
 
   return (
     <SkeletonPlaceholder className={AISkeletonPlaceholderClasses} {...other} />
diff --git a/packages/react/src/components/AISkeleton/__tests__/AISkeleton-test.js b/packages/react/src/components/AISkeleton/__tests__/AISkeleton-test.js
@@ -22,7 +22,6 @@ describe('AISkeleton', () => {
 
     expect(screen.getByTestId('ai-skeleton-placeholder')).toHaveClass(
       'cds--skeleton__placeholder',
-      'className',
       'cds--skeleton__placeholder--ai',
       '💾',
       { exact: true }
diff --git a/packages/react/src/components/Slider/__tests__/Slider-test.js b/packages/react/src/components/Slider/__tests__/Slider-test.js
@@ -1462,7 +1462,7 @@ describe('Slider', () => {
         expect(onChange).not.toHaveBeenCalled();
       });
 
-      it.skip('gracefully tolerates empty event passed to _onDrag', () => {
+      it('gracefully tolerates empty event passed to _onDrag', () => {
         const { mouseDown, mouseUp, mouseMove } = fireEvent;
         const { container } = renderTwoHandleSlider({
           value: initialValueLower,
diff --git a/packages/react/src/components/Switch/IconSwitch.tsx b/packages/react/src/components/Switch/IconSwitch.tsx
@@ -217,9 +217,8 @@ IconSwitch.propTypes = {
    */
   selected: PropTypes.bool,
 
-  // TODO: Icon only variant of what? Isn't the `IconSwitch` always icon only?
   /**
-   * Passed in from `ContentSwitcher` to render icon-only variant
+   * Specify the size of the underlying icon-only button.
    */
   size: PropTypes.oneOf(['sm', 'md', 'lg']),
 
diff --git a/packages/react/src/components/Tabs/Tabs.tsx b/packages/react/src/components/Tabs/Tabs.tsx
@@ -52,6 +52,7 @@ import { Text } from '../Text';
 import BadgeIndicator from '../BadgeIndicator';
 import { isComponentElement } from '../../internal';
 
+const buttonWidth = 44;
 const verticalTabHeight = 64;
 
 // Used to manage the overall state of the Tabs
@@ -503,9 +504,6 @@ function TabList({
   //   SCROLLABLE
   //   AND SCROLL_LEFT > 0
   //
-  // TODO: Hoist `buttonWidth` to a module level constant like
-  // `verticalTabHeight`.
-  const buttonWidth = 44;
   // Next Button
   // VISIBLE IF:
   //   SCROLLABLE
diff --git a/packages/react/src/components/Tile/Tile.tsx b/packages/react/src/components/Tile/Tile.tsx
@@ -251,21 +251,15 @@ export const ClickableTile = React.forwardRef<
       className
     );
 
-    // TODO: Can this be removed? Or is cds--tile--is-clicked supposed to use this instead of `clicked`?
-    // This state is never used
-    const [isSelected, setIsSelected] = useState(clicked);
-
     function handleOnClick(evt: MouseEvent<HTMLAnchorElement>) {
       evt?.persist?.();
-      setIsSelected(!isSelected);
       onClick(evt);
     }
 
     function handleOnKeyDown(evt: KeyboardEvent<HTMLAnchorElement>) {
       evt?.persist?.();
       if (!href && matches(evt, [keys.Enter, keys.Space])) {
         evt.preventDefault();
-        setIsSelected(!isSelected);
         onClick(evt);
       }
       onKeyDown(evt);
