app/src/main/java/me/capcom/smsgateway/modules/messages/MessagesService.kt (1)

426-429: LGTM — allows USSD-style phone numbers when validation is skipped.

The change correctly extends the permissive filter to include * and # characters, which are standard in USSD codes (e.g., *123#) and dial strings. Since this only applies when skipPhoneValidation=true, the strict E.164 validation via PhoneHelper remains the default behavior.

Minor readability suggestion: consider extracting the allowed characters into a constant or using a set for clarity, though this is optional.

♻️ Optional refactor for readability

+private val ALLOWED_PHONE_CHARS = setOf('+', '*', '#')
+
 val normalizedPhoneNumber = when (request.params.skipPhoneValidation) {
-    true -> phoneNumber.filter { it.isDigit() || it == '+' || it == '*' || it == '#' }
+    true -> phoneNumber.filter { it.isDigit() || it in ALLOWED_PHONE_CHARS }
     false -> PhoneHelper.filterPhoneNumber(phoneNumber, countryCode ?: "RU")
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@app/src/main/java/me/capcom/smsgateway/modules/messages/MessagesService.kt`
around lines 426 - 429, Extract the allowed characters used in the permissive
branch into a named constant (e.g., ALLOWED_USSD_CHARS or a Set like
USSD_ALLOWED_CHAR_SET) and replace the inline predicate in the
normalizedPhoneNumber assignment (the branch guarded by
request.params.skipPhoneValidation) with a clear membership check against that
constant/set; keep the PhoneHelper.filterPhoneNumber(countryCode ?: "RU") call
unchanged for the strict branch and reference the symbols normalizedPhoneNumber,
request.params.skipPhoneValidation, and PhoneHelper.filterPhoneNumber when
making the change.