ci: setup GitHub Actions#1782
Merged
Merged
Conversation
nschonni
commented
Jan 7, 2022
| - name: Run browser tests | ||
| run: npm run mocha-browser-test -- --browsers ${{ matrix.browser }} --timeout 10000 | ||
| env: | ||
| DISPLAY: :99.0 |
Contributor
Author
There was a problem hiding this comment.
This might not be needed anymore since switching to FirefoxHeadless
nschonni
commented
Jan 7, 2022
nschonni
left a comment
Contributor
Author
There was a problem hiding this comment.
Can see the run from my fork https://github.com/nschonni/async/actions/runs/1668517012
| - 17 | ||
| os: [ubuntu-latest, macos-latest, windows-latest] | ||
| browser: | ||
| - FirefoxHeadless |
Contributor
Author
There was a problem hiding this comment.
Edge and Safari runners seems to be abandoned and a little flaky, so didn't add them in, but can be added on platform specific includes:
Collaborator
|
Thanks for doing this, I didn't realize Travis has basically shut down. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was hitting some macOS issues that I thought might be coming from here, so i thought it might be good to add back a full test matrix.
I left in the Azure DevOps CI, but only added in 12+ node versions since Node 10 is EOL