Housekeeping#1772
Merged
Merged
Conversation
aearly
approved these changes
Nov 17, 2021
aearly
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this! The docs generation scripts could use a bit of love as well. They were written when async / await support wasn't that great in Node.
Contributor
Author
|
would it be alright to use sync version instead? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When installing all dependencies then it yields some deprecation warnings. some packages wasn't even being used.
Where going to fix some of it but ended up doing something else instead.
Where thinking of removing
fs-extraalso but though if i should ask first...it seems to only be used in development to fix some docs and reading some files
i where thinking that it wouldn't be so bad if it used nodes native
fsafter allAnd b/c it's dev only and mostly one time thing. i think it wouldn't be nice to use the sync api instead to remove some "callback-hell" stuff and avoid the need of async and or promises.
the sync methods are faster after all but they are blocking...