Skip to content

Add concurrency argument to async.auto #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aearly merged 1 commit into from
Oct 26, 2015
Merged

Add concurrency argument to async.auto #637

aearly merged 1 commit into from
Oct 26, 2015

Conversation

@vergenzt
Copy link
Contributor

@vergenzt vergenzt commented Sep 30, 2014

Adds an argument to async.auto to specify maximum concurrency with which to run tasks.

Fixes #635.

@vergenzt
Copy link
Contributor Author

vergenzt commented Sep 30, 2014

The Travis build failed because of someone else's non-deterministic test! :( Mine (auto concurrency) passes...

...
✔ auto
✔ auto concurrency
✔ auto petrify
...

✖ queue pause with concurrency
AssertionError:
[ 'process 1',
  'timeout 0',
  'process 2',
  'timeout 0',
  'process 3',
  'timeout 400',
  'process 4',
  'timeout 400',
  'process 5',
  'timeout 500',
  'process 6',
  'timeout 500' ]
deepEqual
[ 'process 1',
  'timeout 100',
  'process 2',
  'timeout 100',
  'process 3',
  'timeout 400',
  'process 4',
  'timeout 400',
  'process 5',
  'timeout 500',
  'process 6',
  'timeout 500' ]
    at Object.same (/home/travis/build/caolan/async/node_modules/nodeunit/lib/types.js:83:39)
    at null._onTimeout (/home/travis/build/caolan/async/test/test-async.js:2570:14)
    at Timer.listOnTimeout [as ontimeout] (timers.js:112:15)

@vergenzt vergenzt mentioned this pull request Sep 30, 2014
Closed
@vergenzt
Copy link
Contributor Author

vergenzt commented Sep 30, 2014

(FYI I amended the commit (only changed the timestamp) to force a Travis rebuild.)

@cryptoquick
Copy link

cryptoquick commented Nov 1, 2014

👍

@vergenzt
Copy link
Contributor Author

vergenzt commented Dec 13, 2014

Bump. :)

@cryptoquick
Copy link

cryptoquick commented Jan 26, 2015

It would be nice to get back to using mainline async again. I'm still on your fork, @vergenzt
Bump 😄

@aearly
Copy link
Collaborator

aearly commented Oct 25, 2015

If you can fix the conflicts, I'll merge this.

@vergenzt vergenzt force-pushed the auto-concurrency branch 3 times, most recently from ad61fa3 to 5656a11 Compare October 25, 2015 15:14
@vergenzt
Copy link
Contributor Author

vergenzt commented Oct 25, 2015

@aearly Done, rebased to master. Let me know if you need anything else!

aearly added a commit that referenced this pull request Oct 26, 2015
@aearly
Merge pull request #637 from vergenzt/auto-concurrency
fbeab9b 
Add concurrency argument to async.auto
@aearly aearly merged commit fbeab9b into caolan:master Oct 26, 2015
aearly added a commit that referenced this pull request Oct 26, 2015
@aearly
move concurrency arg position in auto (#637)
4a536f1
@aearly
Copy link
Collaborator

aearly commented Oct 26, 2015

Thanks! I swapped the concurrency arg's position to always have the callback as the last arg.

@cryptoquick
Copy link

cryptoquick commented Oct 26, 2015

Awesome! 😸

@vergenzt
Copy link
Contributor Author

vergenzt commented Oct 26, 2015

Sweet. Thanks for merging. :-)

@aearly aearly added this to the 2.0 milestone Mar 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

2.0

Development

Successfully merging this pull request may close these issues.

Limit number of concurrent tasks in async.auto

3 participants

@vergenzt @cryptoquick @aearly