Print the name of the actual missing dependency in async.auto
#1349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can you tweak the test so it checks for the dependency name as well? |
…e contains the missing dependency name
Contributor
Author
|
Sure, no problem. I've pushed up changes that check within the |
Collaborator
|
Thanks a bunch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm not sure if there were specific guidelines to go through before submitting a PR, so apologies if I've missed a step. Now on to the PR:
We've been making use of
async.autoInjectas a light dependency injection framework, and whenever we'd make a mistake in a tasks dependencies we'd end up with a time-consuming task to track down what dependencyasyncwas failing on, because the error message wasn't giving enough to go on.This PR simply adds the actual failed dependency to the error message to trivialize the work of tracking down missing dependencies.