Update to base/Buffer 0.8.7 part 1#11
Merged
Merged
Conversation
|
Any updates on getting these merged? Looks like I have a significant upgrade on my hands when this is ready! Looks like most of my libraries are using v0.2.0. If we need to just fork to v2 that is fine...but I'd like to get the improvements merged in at some point. |
ByronBecker
approved these changes
May 24, 2023
ByronBecker
left a comment
Contributor
There was a problem hiding this comment.
Sorry for the delay @f0i - busy past few weeks and this got buried.
Approved. Ready for part 2 - will review that this weekend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces #10. Thank you for the feedback @ByronBecker!
It contains part of the update to include all features of base/Buffer version 0.8.7.
Part 1 contains updates to all functions that were included in the previous version of StableBuffer.
Test cases are updated to reflect the new capacity calculation.
New functions of Buffer 0.8.7 will get added in batches by future PRs, after this one is approved.