WD-33531: Dev update cta section to support blocks like newer patterns#5769
Merged
immortalcodes merged 5 commits intomainfrom Mar 13, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CTA section pattern in Vanilla Framework docs/examples and the vf_cta_section Jinja macro to support a new blocks API (as a successor to the existing slot-based API), aligning CTA section with newer block-based patterns.
Changes:
- Add
blockssupport tovf_cta_section, reusing sharedvf_description_blockandvf_cta_blockhelpers. - Update CTA section documentation to describe available block types and deprecate slots.
- Migrate CTA section examples to use the new
blocksAPI; bump release notes and package version.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| templates/docs/patterns/cta-section/index.md | Documents new block types, adds blocks param to macro docs, marks slots as deprecated. |
| templates/_macros/vf_cta-section.jinja | Implements blocks parsing/rendering for description + CTA content. |
| templates/docs/examples/patterns/cta-section/description-block.html | New example demonstrating description block usage. |
| templates/docs/examples/patterns/cta-section/cta-block.html | New example demonstrating CTA block usage. |
| templates/docs/examples/patterns/cta-section/default-full-width.html | Migrates example from slots to blocks (HTML CTA). |
| templates/docs/examples/patterns/cta-section/default-full-width-links-within-text.html | Migrates example from slots to blocks (HTML CTA with inline links). |
| templates/docs/examples/patterns/cta-section/default-25-75.html | Migrates example from slots to blocks (HTML CTA). |
| templates/docs/examples/patterns/cta-section/default-25-75-links-within-text.html | Migrates example from slots to blocks (HTML CTA with inline links). |
| templates/docs/examples/patterns/cta-section/block-full-width.html | Migrates block-variant example from slots to blocks (structured CTA). |
| templates/docs/examples/patterns/cta-section/block-25-75.html | Migrates block-variant example from slots to blocks (structured CTA). |
| releases.yml | Adds 4.46.0 entry noting blocks as successor to slots. |
| package.json | Bumps version to 4.46.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
samhotep
reviewed
Mar 11, 2026
Member
samhotep
left a comment
There was a problem hiding this comment.
LGTM, though some checks are failing
samhotep
reviewed
Mar 11, 2026
petesfrench
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
Fixes https://warthogs.atlassian.net/browse/WD-33531
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁,Breaking Change 💣,Bug 🐛,Documentation 📝,Maintenance 🔨.package.jsonshould be updated relative to the most recent release, following semver conventionScreenshots
[if relevant, include a screenshot or screen capture]