Skip to content

[DE-830] Add accessibility review guide for web interfaces#5753

Merged
juanruitina merged 13 commits intomainfrom
DE-830-Publish-review-guide-for-web-interfaces
Feb 18, 2026
Merged

[DE-830] Add accessibility review guide for web interfaces#5753
juanruitina merged 13 commits intomainfrom
DE-830-Publish-review-guide-for-web-interfaces

Conversation

@juanruitina
Copy link
Contributor

@juanruitina juanruitina commented Feb 2, 2026 •
edited
Loading

  • Add new web accessibility guide
    • Includes some guidelines for Vanilla usage specifically, and most content previously available in /accessibility
  • Add page to the documentation navigation
  • Add tab functionality on documentation pages
  • Redirect existing /accessibility page to /docs/accessibility
  • Update references to the accessibility page

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention
    • if existing APIs (CSS classes & macro APIs) are not changed it can be a bugfix release (x.x.X)
    • if existing APIs (CSS classes & macro APIs) are changed/added/removed it should be a minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) or macros should be listed on the what's new page.

@juanruitina juanruitina added the Documentation 📝 Documentation changes or updates label Feb 2, 2026
@webteam-app
Copy link

webteam-app commented Feb 2, 2026

Demo

Jenkins

demos.haus

@juanruitina
Iterate accessibility guide
eba31a4 
Add guidance for Vanilla users
Integrate advice, references from previous checklist
Clean links
@juanruitina
Iterate accessibility guide
b5a661e 
Address inconsistencies in screen reader guides
Incorporate feedback from Claude's critique
@juanruitina
Remove and redirect /accessibility
7e2d9c3
jmuzina
jmuzina reviewed Feb 6, 2026
View reviewed changes
Copy link
Member

@jmuzina jmuzina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this! I have a few comments below.

Btw: your PR is failing our formatter in CI. Run npx prettier -c -w . to apply auto-formatting fixes which should correct this :)

@juanruitina
Copy link
Contributor Author

juanruitina commented Feb 9, 2026

Thank you @jmuzina for your feedback, I incorporated it all 👏🏻

@juanruitina juanruitina changed the title [DE-830] Add review guide for web interfaces [DE-830] Add accessibility review guide for web interfaces Feb 16, 2026
@juanruitina juanruitina marked this pull request as ready for review February 18, 2026 12:54
@jmuzina jmuzina self-assigned this Feb 18, 2026
jmuzina
jmuzina approved these changes Feb 18, 2026
View reviewed changes
Copy link
Member

@jmuzina jmuzina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your work on this!

@jmuzina jmuzina added Review: Percy needed This PR needs a review of Percy for visual regressions Review: QA +1 Review: Code +1 and removed Review: QA needed labels Feb 18, 2026
@juanruitina juanruitina added Review: Percy +1 and removed Review: Percy needed This PR needs a review of Percy for visual regressions labels Feb 18, 2026
@jmuzina jmuzina removed their assignment Feb 18, 2026
@juanruitina juanruitina merged commit eca812c into main Feb 18, 2026
12 checks passed
@juanruitina juanruitina deleted the DE-830-Publish-review-guide-for-web-interfaces branch February 18, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmuzina jmuzina jmuzina approved these changes

Assignees

No one assigned

Labels

Accessibility Documentation 📝 Documentation changes or updates Review: Code +1 Review: Percy +1 Review: QA +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@juanruitina @webteam-app @jmuzina