Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4945 +/- ##
==========================================
+ Coverage 89.64% 89.66% +0.01%
==========================================
Files 334 335 +1
Lines 22401 22458 +57
==========================================
+ Hits 20082 20137 +55
- Misses 2319 2321 +2 ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
CI is failing because this reference is excluded here |
mattculler
approved these changes
Jul 31, 2024
1 task
5954426 to
2d6d7ac
Compare
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
2d6d7ac to
8d39284
Compare
cmatsuoka
approved these changes
Aug 5, 2024
cmatsuoka
reviewed
Aug 5, 2024
Contributor
|
The implementation seems good, but we should test valid component names using names containing numbers. |
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tox run -m lint?tox run -e test-py310? (supported versions:py39,py310,py311,py312)Depends on canonical/craft-parts#790
Fixes LP#2069783
(CRAFT-3043)