snap-patch/netplan: do not write files for temporary connections#15
Merged
alfonsosanchezbeato merged 4 commits intosnap-22from Mar 23, 2023
Merged
snap-patch/netplan: do not write files for temporary connections#15alfonsosanchezbeato merged 4 commits intosnap-22from
alfonsosanchezbeato merged 4 commits intosnap-22from
Conversation
slyon
approved these changes
Mar 23, 2023
Contributor
slyon
left a comment
There was a problem hiding this comment.
Thank you, this LGTM! Looks like the spread test (GitHub action passed, too).
Just a few (non-blocking) suggestions inline.
I've also confirmed our autopkgtest is now passing, using this source package: https://git.launchpad.net/network-manager/log/?h=netplan/lunar-gu
I confirmed our (previously failing) autopkgtest passes now for the OpenVPN duplicate connections fix: https://paste.ubuntu.com/p/FWTVxbjzC6/ (especially the TestNetplan.test_openvpn_connection case)
The change already landed in the "Netplan Everywhere" PPA: https://launchpad.net/~canonical-foundations/+archive/ubuntu/networkmanager-netplan
snap-patch/networkmanager/0002-netplan-make-use-of-libnetplan-for-YAML-backend.patch
Outdated
Show resolved
Hide resolved
Co-authored-by: Lukas Märdian <slyon@ubuntu.com>
Co-authored-by: Lukas Märdian <slyon@ubuntu.com>
Member
Author
|
@slyon thanks for the suggestions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes LP:#1998207.