Questionnaire: Improve flow for fingerprint verification#954
Merged
roosterfish merged 7 commits intocanonical:mainfrom Sep 4, 2025
Merged
Questionnaire: Improve flow for fingerprint verification#954roosterfish merged 7 commits intocanonical:mainfrom
roosterfish merged 7 commits intocanonical:mainfrom
Conversation
This is a request raised in canonical#949. When printing the fingerprint verification info before entering the passphrase, we are telling the user to perform an action even though this can only be done after entering the passphrase and the joiner reached out to the initator. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
We usually prefix the system names with system Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
We only highlight text that stands out. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
We only require a single newline here. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
In case you decide to again remove the last part of the passphrase you cannot anymore because the text input is blurred. Instead only blur the text input when exiting the model. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
d315ad6 to
22d0858
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #949.
We should not tell the user to verify the joiners fingerprint before this can actually be done on the initiator to avoid confusion.
Furthermore it fixes a few smaller inconsistencies in the new autocomplete tui model.