Skip to content

Service: Increase the context deadline for adding MicroCeph disks#894

Merged
roosterfish merged 1 commit intocanonical:mainfrom
roosterfish:fix_disk_add_deadline
Jul 25, 2025
Merged

Service: Increase the context deadline for adding MicroCeph disks#894
roosterfish merged 1 commit intocanonical:mainfrom
roosterfish:fix_disk_add_deadline

Conversation

@roosterfish
Copy link
Contributor

During pipeline execution (e.g. https://github.com/canonical/microcloud/actions/runs/16517071789/job/46710255729?pr=893) we sometimes see that the request to add disks to MicroCeph exceeds the request context's deadline.

By default this deadline is set to 30s by the underlying Microcluster client. However when adding a large amount of disks we should give MicroCeph time to perform the necessary actions.

This should address one of the errors in #653:

⨯ Error: Failed to request disk addition: Post "http://control.socket/1.0/services/microceph/1.0/disks?target=micro01": context deadline exceeded

During pipeline execution (e.g. https://github.com/canonical/microcloud/actions/runs/16517071789/job/46710255729?pr=893)
we sometimes see that the request to add disks to MicroCeph exceeds the request context's deadline.

By default this deadline is set to 30s by the underlying Microcluster client.
However when adding a large amount of disks we should give MicroCeph time to perform the necessary actions.

Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
@roosterfish roosterfish requested a review from markylaing July 25, 2025 09:04
@roosterfish roosterfish mentioned this pull request Jul 25, 2025
@roosterfish
Copy link
Contributor Author

In the long run MicroCeph could maybe have something like LXD's operations which would allow waiting until the job is done.

@roosterfish roosterfish requested a review from tomponline July 25, 2025 11:32
@roosterfish roosterfish merged commit 9a4685c into canonical:main Jul 25, 2025
53 of 54 checks passed
@roosterfish roosterfish deleted the fix_disk_add_deadline branch July 25, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants