fix/ci: Wait for RBD mirror health before testing disable operations#696
Merged
UtkarshBhatthere merged 1 commit intocanonical:mainfrom Mar 20, 2026
Merged
fix/ci: Wait for RBD mirror health before testing disable operations#696UtkarshBhatthere merged 1 commit intocanonical:mainfrom
UtkarshBhatthere merged 1 commit intocanonical:mainfrom
Conversation
Signed-off-by: John Ramsden <john.ramsden@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
remote_disable_rbd_mirroringin actionutils.sh runs disable commands immediately, but the pool replication health may not yet be OK if images are still syncing.The health check in handlePoolDisablement likely fails with "pool replication status not OK(%s), Can't proceed" instead of the expected "in Image mirroring mode" error.
wait until replication health is okay prior to running this.
Fixes #692
Type of change
Delete options that are not relevant.
How has this been tested?
Run CI until health != OK, verify wait occurs and health=ERROR transitions to OK
EG: https://github.com/johnramsden/microceph/actions/runs/23274231388/job/67676935942
Contributor checklist
Please check that you have: