Skip to content

fix/ci: Wait for RBD mirror health before testing disable operations#696

Merged
UtkarshBhatthere merged 1 commit intocanonical:mainfrom
johnramsden:RBD-693
Mar 20, 2026
Merged

fix/ci: Wait for RBD mirror health before testing disable operations#696
UtkarshBhatthere merged 1 commit intocanonical:mainfrom
johnramsden:RBD-693

Conversation

@johnramsden
Copy link
Member

Description

remote_disable_rbd_mirroring in actionutils.sh runs disable commands immediately, but the pool replication health may not yet be OK if images are still syncing.

The health check in handlePoolDisablement likely fails with "pool replication status not OK(%s), Can't proceed" instead of the expected "in Image mirroring mode" error.

wait until replication health is okay prior to running this.

Fixes #692

Type of change

Delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Run CI until health != OK, verify wait occurs and health=ERROR transitions to OK

EG: https://github.com/johnramsden/microceph/actions/runs/23274231388/job/67676935942

Contributor checklist

Please check that you have:

  • self-reviewed the code in this PR
  • added code comments, particularly in less straightforward areas
  • checked and added or updated relevant documentation
  • checked and added or updated relevant release notes
  • added tests to verify effectiveness of this change

Signed-off-by: John Ramsden <john.ramsden@canonical.com>
@johnramsden johnramsden self-assigned this Mar 19, 2026
@johnramsden johnramsden added the CI GitHub CI-related issues label Mar 19, 2026
@johnramsden johnramsden linked an issue Mar 19, 2026 that may be closed by this pull request
Copy link
Contributor

@UtkarshBhatthere UtkarshBhatthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@UtkarshBhatthere UtkarshBhatthere merged commit 72961d6 into canonical:main Mar 20, 2026
22 checks passed
@johnramsden johnramsden deleted the RBD-693 branch March 20, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI GitHub CI-related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MicroCeph Quality Improvements CI: Test MicroCeph RBD Remote Replication features fails frequently

2 participants