fix: rgw --port is not respected#504
Merged
sabaini merged 1 commit intocanonical:mainfrom Feb 11, 2025
Merged
Conversation
056912f to
344a552
Compare
Contributor
Author
|
Update, I signed the CLA. |
Collaborator
|
Heya @Gu1nness , many thanks for the fix+test! Sorry abt the CLA hassle. Afaict the CLA check looks at either the Github account org membership or the mailaddress used to sign the commits maybe this helps? |
Contributor
Author
For the github account org membership, I'm part of Canonical org so it shouldn't be an issue. |
cfd1ea9 to
07a276d
Compare
This regression was introduced in canonical#355. This change was tested with an update of the current unit tests. Closes: canonical#483 Signed-off-by: Neha Oudin <neha.oudin@canonical.com>
07a276d to
05a5068
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #355 a regression was added where the
--portrgw option is not respected.This PR fixes this regression, updates the tests in order to ensure that it is respected in all contexts.
Fixes #483
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
The unit tests were updated to reflect that change and confirm that the option is respected when it is passed.
Contributor's Checklist
Please check that you have: