Add test coverage for RegisterEtcdMemberReverter error handling#7
Closed
Copilot wants to merge 4 commits into
Closed
Add test coverage for RegisterEtcdMemberReverter error handling#7Copilot wants to merge 4 commits into
Copilot wants to merge 4 commits into
Conversation
Signed-off-by: Louise K. Schmidtgen <louise.schmidtgen@canonical.com>
- Extended snap mock to support EtcdClient error scenarios - Added test for etcd client creation failure handling - Added test for successful join scenario (reverter doesn't run) - Tests verify directory is preserved when client creation fails - Tests verify directory is preserved on successful joins Co-authored-by: louiseschmidtgen <107889048+louiseschmidtgen@users.noreply.github.com>
Address code review feedback to remove defer reverter.Fail() since reverter.Success() is explicitly called and clears hooks. Co-authored-by: louiseschmidtgen <107889048+louiseschmidtgen@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] WIP: Address feedback on node join reverter implementation
Add test coverage for RegisterEtcdMemberReverter error handling
Jan 27, 2026
3eb5b61 to
ba7f80d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback requesting test coverage for
RegisterEtcdMemberRevertercleanup logic with 3+ endpoints, including error handling scenarios.Changes
EtcdClientErrfield to enable testing etcd client creation failuresTestRegisterEtcdMemberReverter_ClientCreationFailure: Verifies directory preservation when client creation fails (3+ endpoints)TestRegisterEtcdMemberReverter_Success: Verifies no cleanup occurs on successful joinsetcd.Clientembeds concrete types rather than interfacesTest Coverage
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.