fix: [chore] capitalize node name duplication errors to publicize them#14
Closed
ethandcosta wants to merge 1 commit into
Closed
fix: [chore] capitalize node name duplication errors to publicize them#14ethandcosta wants to merge 1 commit into
ethandcosta wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Exports node-name duplication related sentinel errors by capitalizing their identifiers so they can be consumed by external tooling (k8s-snap).
Changes:
- Renamed
errNodeNameAlreadyExists→ErrNodeNameAlreadyExists - Renamed
errFailedToCheckNodeName→ErrFailedToCheckNodeName
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
23
to
26
| var ( | ||
| errNodeNameAlreadyExists = errors.New("a node with this name is already part of the cluster") | ||
| errFailedToCheckNodeName = errors.New("failed to check whether node name is available in cluster") | ||
| ErrNodeNameAlreadyExists = errors.New("a node with this name is already part of the cluster") | ||
| ErrFailedToCheckNodeName = errors.New("failed to check whether node name is available in cluster") | ||
| ) |
There was a problem hiding this comment.
These identifiers are now exported. Please add Go doc comments for each (or for the var block) so golint/staticcheck (e.g., ST1005/ST1020-style checks) and godoc have proper documentation. Comments should start with the identifier name (e.g., // ErrNodeNameAlreadyExists ...).
Contributor
Author
|
This PR is no longer necessary because we are not consuming the error names in k8s-snap |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR capitalizes the node name duplication errors so they can be exported to k8s-snap