fix: address panic in response handling and better handling for ModelStatus api method#1895
Merged
kian99 merged 2 commits intocanonical:v3from Mar 6, 2026
Merged
Conversation
SimoneDutto
reviewed
Mar 6, 2026
SimoneDutto
approved these changes
Mar 6, 2026
ale8k
approved these changes
Mar 6, 2026
| Error: &jujuparams.Error{ | ||
| } | ||
| if sb.Error != nil { | ||
| res.Error = &jujuparams.Error{ |
Contributor
There was a problem hiding this comment.
We always get caught by this (Incoming AI prompt: "create me a linter that verifies all nested errors in Juju responses are properly handled") 😆
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes two issues that are causing test failures between the Terraform provider and the latest version of JIMM.
toFullModelInfobecause we were not checking if theErrorfield was nil before using it.ModelStatusreturns the status of a single model but the underlying API request is a bulk one, so any errors are not surfaced in theerrvalue and instead captured as a field on the list of responses.To test the fix for the latter I've added an integration style test in the
testingpackage. Ideally we would have the dial_test.go file inside of thejujuclientpackage and allow integration style tests from any package but our CI is currently setup to only run integration tests from thetestingpackage. So this will need some further thought and work.Engineering checklist