fix: handle scenarios with nil machine info#1894
Merged
kian99 merged 2 commits intocanonical:v3from Mar 5, 2026
Merged
Conversation
SimoneDutto
approved these changes
Mar 5, 2026
alesstimec
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a panic in the
toModelInfofunction when Juju returns nil for machine info. I previously didn't add unit tests for this mapping function because it's tested in our integration tests but running the Terraform provider tests against the latest JIMM, I saw we were encountering a panic when destroying a model/application. During destruction there seems to be times when the Juju controller reports anilvalue for machine info, and we were not correctly handling that.I've now added some unit tests for this case and the successful case.
Engineering checklist