feat: tweak remove-controller logic#1893
Merged
kian99 merged 2 commits intocanonical:v3from Mar 4, 2026
Merged
Conversation
6713b2c to
c5d252e
Compare
luci1900
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the remove-controller logic in JIMM. Previously it required that a controller was "unavailable" i.e. that JIMM hadn't been able to connect to it recently, then a remove-controller request would delete from JIMM's database all the models on that controller and the controller itself. The
forceflag could be used to bypass the "unavailable" check.Now, the controller must have no models before it can be deleted. The
forceflag can be used to skip this check and keep the pre-existing behaviour.Fixes JUJU-9189
Engineering checklist