test: simplify model creation in tests#1887
Merged
kian99 merged 3 commits intocanonical:v3from Feb 26, 2026
Merged
Conversation
5df5bd5 to
e54ec6f
Compare
e54ec6f to
037bb11
Compare
luci1900
reviewed
Feb 25, 2026
ale8k
approved these changes
Feb 25, 2026
Contributor
ale8k
left a comment
There was a problem hiding this comment.
LGTM nice work on this cleans it up a lot, I would prefer we remove the names inside of function signatures though and just pass a user.
luci1900
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR does 2 things,
JimmWithControllersandWebsocketEnv. There were no usages of the former except within the latter, so I've merged them, keeping the nameJimmWithControllersas I think it's clearer.I had AI do some of the refactoring and it made what I think is a nice change. It created helper functions
CreateModelForBobandCreateModelForCharlie. Our tests always used these users and setup permissions for them so I've called out their roles (and Alice's role) in a godoc. Charlie and Bob have add-model permissions on all controllers and Alice is a superuser.The tests, I think, are easy to read when you have the above in mind.
As an interesting note, creation of a model + teardown consumes about 3s.
Engineering checklist