test: use new integration test suite for dial tests#1879
test: use new integration test suite for dial tests#1879kian99 merged 4 commits intocanonical:v3from
Conversation
| "github.com/canonical/jimm/v3/internal/testutils/jimmtest" | ||
| ) | ||
|
|
||
| type jujuclientSuite struct { |
2fb181c to
e70a123
Compare
|
@SimoneDutto One tricky thing with this PR, I've had to move the |
yeah, we can try. At the time of setting up these things unit tests were still half e2e and half unit. |
| @@ -0,0 +1,115 @@ | |||
| // Copyright 2025 Canonical. | |||
There was a problem hiding this comment.
I was about to say "Lol good one" until I realised this was a legitimate comment. I just moved the file and made some tweaks but I guess git is seeing that as too many changes to count as a rename - see internal/jujuclient/dial_test.go which was removed in this PR.
|
|
||
| var _ = gc.Suite(&dialSuite{}) | ||
|
|
||
| func (s *dialSuite) TestDial(c *gc.C) { |
There was a problem hiding this comment.
we could take it a step further and get rid of gc in favor of qt.. but..
There was a problem hiding this comment.
Currently working on that 👍
e70a123 to
5bb9f38
Compare
5bb9f38 to
d522b22
Compare
Description
This PR updates the dial tests in the
jujuclientto use the new test suite that uses real Juju controllers and removes the final usages of Juju's ConnSuite (but doesn't remove the ConnSuite itself just yet).I've also removed the
jujuclientpackage's test filescloud_test.goandstorage_test.gowhich are being removed in #1876 and another pending PR for switching clouds over to the Juju API client.It's worth noting that tests like
TestDialare taking > 5s because the suite creates 3 models and then tears them down at the end. In a follow-up PR I'll look at making this model setup optional.Engineering checklist