Merged
Conversation
ale8k
reviewed
Feb 17, 2026
| } | ||
|
|
||
| // RoleManager provides a means to manage roles within JIMM. | ||
| type RoleManager interface { |
9de259e to
318a125
Compare
318a125 to
afa2214
Compare
luci1900
reviewed
Feb 17, 2026
internal/jujuapi/jimm_adapter.go
Outdated
| @@ -0,0 +1,72 @@ | |||
| // Copyright 2026 Canonical. | |||
Contributor
There was a problem hiding this comment.
I still don't like this, but at least it's in one place.
luci1900
approved these changes
Feb 17, 2026
Contributor
luci1900
left a comment
There was a problem hiding this comment.
Sure.
I felt we were overusing package privacy anyway.
alesstimec
approved these changes
Feb 18, 2026
Collaborator
alesstimec
left a comment
There was a problem hiding this comment.
LGTM, but without the copyright year changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR we refactor where certain interfaces are defined. Currently we define several interfaces in
internal/jimm/that define what each of the domain packages exposes i.e. we have aGroupManagerinterface that defines the methods thegroup.groupManagerstruct exposes (notice that the struct itself is not exported). This works but ideally we'd define the interfaces where they are consumed instead ininternal/jujuapiandinternal/jimmhttp/rebac_admin.This PR moves those interface definitions to
internal/jujuapiand therebac_adminpackage re-uses them. Functionally not much has changed, but possibly this provides more clarity when navigating the codebase.