Skip to content

feat: return error when job is duplicate#1865

Merged
kian99 merged 2 commits intocanonical:v3from
kian99:handle-river-duplicates
Feb 13, 2026
Merged

feat: return error when job is duplicate#1865
kian99 merged 2 commits intocanonical:v3from
kian99:handle-river-duplicates

Conversation

@kian99
Copy link
Contributor

@kian99 kian99 commented Feb 13, 2026

Description

This PR ensures that when a client requests a bootstrap/controller-destroy/upgrade-to job, we return an error if the job inserted was a duplicate (i.e. if a job was still busy running).

As a drive-by I also made 2 other changes,

  • Added timeouts to the upgrade/migrate/upgrade-to River workers (to avoid the default timeout of 1m).
  • Added a check to the migrate logic that returns early if the migration failed.

Fixes JUJU-9159

Engineering checklist

  • Documentation updated
  • Covered by unit tests
  • Covered by integration tests

@kian99 kian99 requested a review from a team as a code owner February 13, 2026 11:42
@kian99 kian99 merged commit 1f52322 into canonical:v3 Feb 13, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants