Skip to content

refactor: move to mocked unit tests for roles cmd#1860

Merged
luci1900 merged 1 commit intocanonical:v3from
luci1900:refactor/roles-cmd
Feb 10, 2026
Merged

refactor: move to mocked unit tests for roles cmd#1860
luci1900 merged 1 commit intocanonical:v3from
luci1900:refactor/roles-cmd

Conversation

@luci1900
Copy link
Contributor

@luci1900 luci1900 commented Feb 9, 2026

Description

Refactor the role-related commands to unit tests. There already are integration tests for the endpoints.

Engineering checklist

  • Documentation updated
  • Covered by unit tests
  • Covered by integration tests

@luci1900 luci1900 changed the title refactor: move to mocked unit tests for permissions cmd refactor: move to mocked unit tests for roles cmd Feb 9, 2026
@luci1900 luci1900 marked this pull request as ready for review February 9, 2026 16:47
@luci1900 luci1900 requested a review from a team as a code owner February 9, 2026 16:47
Copy link
Contributor

@ale8k ale8k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@luci1900 luci1900 merged commit 5739220 into canonical:v3 Feb 10, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants