refactor: move to mocked unit tests for permissions cmd#1859
Merged
luci1900 merged 1 commit intocanonical:v3from Feb 10, 2026
Merged
refactor: move to mocked unit tests for permissions cmd#1859luci1900 merged 1 commit intocanonical:v3from
luci1900 merged 1 commit intocanonical:v3from
Conversation
ale8k
reviewed
Feb 9, 2026
Contributor
|
I also checked all this is covered in our e2e tests and it is so after the addition flags tests this looks good to me. |
kian99
approved these changes
Feb 10, 2026
3 tasks
c6f7b62 to
fd44530
Compare
fd44530 to
3e1b3d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor the permissions-related commands to unit tests. There already are integration tests for the endpoints.
Engineering checklist