refactor: purge logs cmd unit test#1847
Merged
kian99 merged 2 commits intocanonical:v3from Feb 4, 2026
Merged
Conversation
SimoneDutto
approved these changes
Feb 4, 2026
luci1900
approved these changes
Feb 4, 2026
123171d to
8479ab8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR tweaks the
purge-logscommand to make it unit-testable. It also moves the API test for purge logs to thetestingpackage since we didn't have another test for this.Fixes JUJU-9018
Engineering checklist