refactor(cmd): remove store field and fixes errors#1840
Merged
alesstimec merged 1 commit intocanonical:v3from Jan 28, 2026
Merged
refactor(cmd): remove store field and fixes errors#1840alesstimec merged 1 commit intocanonical:v3from
alesstimec merged 1 commit intocanonical:v3from
Conversation
Removes the `store` field, because there already is one in the `ControllerCommandBase`, and improves the returned errors.
a2c43a4 to
6fc48c9
Compare
kian99
approved these changes
Jan 28, 2026
luci1900
approved these changes
Jan 28, 2026
Contributor
luci1900
left a comment
There was a problem hiding this comment.
I suppose even if we had to wrap the filestore this would still work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the
storefield, because there already is one in theControllerCommandBase, and improves the returned errors.Engineering checklist
Test instructions