refactor: add unit tests to modelstatus command#1833
Merged
kian99 merged 4 commits intocanonical:v3from Jan 27, 2026
Merged
Conversation
SimoneDutto
reviewed
Jan 27, 2026
SimoneDutto
approved these changes
Jan 27, 2026
alesstimec
approved these changes
Jan 27, 2026
Collaborator
alesstimec
left a comment
There was a problem hiding this comment.
LGTM with a few comments (i think a rebase is needed, too)
c86255d to
a13e949
Compare
The documentation command has an extra space in the example strings. We import this functionality so we can't fix it here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the
modelstatuscommand and its tests to unit tests from integration tests.Fixes JUJU-9016
Engineering checklist