test: refactor destroy controller test away from gocheck#1828
Merged
kian99 merged 1 commit intocanonical:v3from Jan 22, 2026
Merged
test: refactor destroy controller test away from gocheck#1828kian99 merged 1 commit intocanonical:v3from
kian99 merged 1 commit intocanonical:v3from
Conversation
alesstimec
approved these changes
Jan 22, 2026
luci1900
approved these changes
Jan 22, 2026
ale8k
reviewed
Jan 22, 2026
| for i, test := range tests { | ||
| c.Log("Test ", i) | ||
| command := &destroyControllerCommand{} | ||
| command.SetClientStore(jujuclienttesting.MinimalStore()) |
Contributor
There was a problem hiding this comment.
Didn't know about MinimalStore - nice!
| c.Assert(err, qt.IsNil) | ||
| } | ||
|
|
||
| func TestWatchLogs(t *testing.T) { |
Contributor
There was a problem hiding this comment.
Would be good to have a test for the prompting? We could pass a buffer to our own cmd.Ctx and capture what it writes, and then even test the success using the prompt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the
destroy-controllercommands tests away fromgocheck. There was no refactoring to the implementation since it was already mocking the API connection.Fixes JUJU-9006
Engineering checklist