test: refactor import model tests#1826
Merged
ale8k merged 5 commits intocanonical:v3from Jan 30, 2026
Merged
Conversation
alesstimec
reviewed
Jan 22, 2026
kian99
approved these changes
Jan 22, 2026
85b1542 to
dca0a18
Compare
alesstimec
approved these changes
Jan 27, 2026
Collaborator
alesstimec
left a comment
There was a problem hiding this comment.
LGTM with a few comments - perhaps we need to discuss the store field
dca0a18 to
7e1d9ad
Compare
f61d306 to
05f85d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors import model tests. I did a similar thing as I did previously where we validate the args are passed correctly.
Engineering checklist
Test instructions