test: refactor grantauditlog tests into unit tests#1824
Merged
ale8k merged 5 commits intocanonical:v3from Jan 22, 2026
Merged
Conversation
kian99
approved these changes
Jan 22, 2026
alesstimec
approved these changes
Jan 22, 2026
a264db3 to
59d61a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors grant audit log access tests into unit tests.
I added an additional bit of validation to the user tag as we were creating new name tag and it could have panicked. So we now validate in the Init() func. I've added a test to validate this.
Engineering checklist
Test instructions