test: addcloudtocontroller unit test#1817
Merged
ale8k merged 7 commits intocanonical:v3from Jan 20, 2026
Merged
Conversation
kian99
approved these changes
Jan 19, 2026
| } | ||
|
|
||
| func (s *addCloudToControllerSuite) TestAddCloudToController(c *gc.C) { | ||
| c.Skip("This test is failing since 3.6.12 since the providers moved to internal.") |
Contributor
There was a problem hiding this comment.
We have a card on the backlog to fix this, since we are removing this please check that we have an equivalent test for this in our e2e testing suite.
Contributor
There was a problem hiding this comment.
Taking another look at this, I recall that it was the CLI logic that was failing to parse a cloud due to the lack of providers. I believe we still need some kind of test that will be failing due to this issue.
be5ddda to
e63c375
Compare
kian99
requested changes
Jan 20, 2026
Contributor
kian99
left a comment
There was a problem hiding this comment.
Just requesting changes to override my previous approval. We need a test like the previous TestAddCloudToController that is verifying the parsing of clouds logic.
kian99
approved these changes
Jan 20, 2026
…e client creation
Instead of using the entire ReadCloudFromFile call, we simply parse the metadata ourselves and let the controller validate the clouds keys. This way it doesn't matter if the parsing logic is internal to the provider.
1a2d665 to
deb2313
Compare
luci1900
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors add cloud to controller into a unit test. I've also added a single place to create JIMM API clients as:
Engineering checklist
Test instructions