Skip to content

test: update cross model query cmd#1815

Merged
kian99 merged 3 commits intocanonical:v3from
kian99:update-cross-model-query-cmd
Jan 20, 2026
Merged

test: update cross model query cmd#1815
kian99 merged 3 commits intocanonical:v3from
kian99:update-cross-model-query-cmd

Conversation

@kian99
Copy link
Contributor

@kian99 kian99 commented Jan 19, 2026

Description

This PR updates the cross-model query JAAS command. It enables mocking out the API client and refactors the tests to unit tests. It also adds some common helpers that are useful across all unit-tested commands.

Fixes JUJU-9003

Engineering checklist

  • Documentation updated
  • Covered by unit tests
  • Covered by integration tests

@kian99 kian99 requested a review from a team as a code owner January 19, 2026 10:44
Copy link
Contributor

@luci1900 luci1900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As much as I dislike mocks and the APIFunc pattern in cmds, this is nice.

@kian99 kian99 merged commit 1261a05 into canonical:v3 Jan 20, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants