fix: e2e suite DeployApplication on non-amd64 architectures#1778
Merged
luci1900 merged 1 commit intocanonical:v3from Dec 18, 2025
Merged
fix: e2e suite DeployApplication on non-amd64 architectures#1778luci1900 merged 1 commit intocanonical:v3from
luci1900 merged 1 commit intocanonical:v3from
Conversation
SimoneDutto
approved these changes
Dec 17, 2025
This was noticed by trying to run the tests on Ubuntu arm64.
0175bf9 to
5cc4534
Compare
3 tasks
ale8k
approved these changes
Dec 18, 2025
Contributor
ale8k
left a comment
There was a problem hiding this comment.
The arm gods appreciate this!
| ApplicationName: appName, | ||
| Channel: utils.Ptr("latest/stable"), | ||
| NumUnits: utils.Ptr(1), | ||
| Cons: constraints.Value{Arch: utils.Ptr(runtime.GOARCH)}, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pass the architecture constraint into the E2E suite's
DeployApplication. By default, if there is no arch constraint Juju fills inamd64.This was noticed by trying to run the tests on an Ubuntu
arm64VM. To me this seems like a wider problem that will need addressing in many Juju-related tools.Engineering checklist
Test instructions
Run the E2E tests, or specifically
TestListModelSummaries.I'd appreciate someone trying this on
amd64as well to make sure I haven't broken it.