Skip to content

fix: e2e suite DeployApplication on non-amd64 architectures#1778

Merged
luci1900 merged 1 commit intocanonical:v3from
luci1900:fix-deploy-application
Dec 18, 2025
Merged

fix: e2e suite DeployApplication on non-amd64 architectures#1778
luci1900 merged 1 commit intocanonical:v3from
luci1900:fix-deploy-application

Conversation

@luci1900
Copy link
Contributor

Description

Pass the architecture constraint into the E2E suite's DeployApplication. By default, if there is no arch constraint Juju fills in amd64.

This was noticed by trying to run the tests on an Ubuntu arm64 VM. To me this seems like a wider problem that will need addressing in many Juju-related tools.

Engineering checklist

  • Documentation updated
  • Covered by unit tests
  • Covered by integration tests

Test instructions

Run the E2E tests, or specifically TestListModelSummaries.

I'd appreciate someone trying this on amd64 as well to make sure I haven't broken it.

@luci1900 luci1900 requested a review from a team as a code owner December 17, 2025 15:53
@luci1900 luci1900 requested a review from ale8k December 17, 2025 15:53
This was noticed by trying to run the tests on Ubuntu arm64.
@luci1900 luci1900 force-pushed the fix-deploy-application branch from 0175bf9 to 5cc4534 Compare December 17, 2025 16:00
@canonical canonical deleted a comment from github-actions bot Dec 17, 2025
Copy link
Contributor

@ale8k ale8k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The arm gods appreciate this!

ApplicationName: appName,
Channel: utils.Ptr("latest/stable"),
NumUnits: utils.Ptr(1),
Cons: constraints.Value{Arch: utils.Ptr(runtime.GOARCH)},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BEAUTIFUL

@luci1900 luci1900 merged commit 8680681 into canonical:v3 Dec 18, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants