test(migrate-suite): removed modelManagerStorageSuite and migrated caasModelManagerSuite#1771
Merged
SimoneDutto merged 2 commits intocanonical:v3from Jan 8, 2026
Conversation
6bc4bfd to
d0c2876
Compare
SimoneDutto
commented
Dec 15, 2025
luci1900
reviewed
Dec 15, 2025
kian99
reviewed
Dec 15, 2025
d0c2876 to
1b78731
Compare
luci1900
previously approved these changes
Dec 16, 2025
Contributor
luci1900
left a comment
There was a problem hiding this comment.
Looks good, barring the linter errors left.
61d7ba0 to
038a6fa
Compare
kian99
previously approved these changes
Jan 5, 2026
Contributor
Author
|
converting it to a draft because it has some challenge i prefer to discuss once we've moved all the others |
038a6fa to
5a2c16b
Compare
77136d6 to
d8d0a50
Compare
0cc9d4a to
3ead48d
Compare
SimoneDutto
commented
Jan 8, 2026
Contributor
Author
There was a problem hiding this comment.
this should be a git mv from modelmanager_test.go plus some changes, but git is stupid when you change too many things
3ead48d to
0dfd396
Compare
everything changed
1f85759 to
95ffc7b
Compare
luci1900
reviewed
Jan 8, 2026
| sudo iptables -F FORWARD && \ | ||
| sudo iptables -P FORWARD ACCEPT | ||
luci1900
reviewed
Jan 8, 2026
| JAAS functionalities. | ||
|
|
||
| After setting up microk8s we add the k8s cloud to the client: | ||
| `juju add-k8s microk8s-cp --client` |
Contributor
There was a problem hiding this comment.
Why -cp? Maybe -e2e would be more obvious?
luci1900
approved these changes
Jan 8, 2026
Contributor
luci1900
left a comment
There was a problem hiding this comment.
Looks good, I have mere nits to pick.
Tasty deleted code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed modelManagerStorageSuite because it wasn't testing any particular JIMM feature, and it would have required to deploy an application with storage (ex. postgres) with all the hassle of waiting for it to be ready, creating the storage etc
caasModelManagerSuite migrated.