Update reference app to ensure root views of regular windows remain in the same view collection #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the reference app so that the root view of a regular window stays in the topmost view collection instead of being anchored to the view of the main window. This ensures that the
FocusTraversalGroupof the root view is a child of the root focus scope rather than a nested scope.Why does this matter? Because it fixes an issue where focus sometimes switches back and forth indefinitely between two regular windows. Specifically, the issue occurs when switching focus from a root view A to a root view B while B's focus scope is nested in A's focus scope. When the user activates the top-level window with root view B and the focus goes to B, A's
View::_scopeFocusChangeListenerdetects that the focused scope does not match the newly focused view (B) and requests a focus change back to A. However, when A regains focus, B'sView::_scopeFocusChangeListenerthen notices that B is not focused while its scope node is (since it's inside A's scope) and requests a focus change to B, restarting the loop.