feat(24.04): add ubuntu archive signing key 2018#81
feat(24.04): add ubuntu archive signing key 2018#81cjdcordeiro merged 3 commits intocanonical:ubuntu-24.04from
Conversation
This commit adds the Ubuntu Archive Automatic Signing Key (2018) as a
"public-key" in the chisel.yaml. The armored data was obtained by
executing the following commands on a Ubuntu 22.04 machine:
$ gpg --keyserver keyserver.ubuntu.com --receive-keys 871920D1991BC93C
$ gpg --armor --export 871920D1991BC93C
BREAKING CHANGE: This commit introduces the new chisel yaml format
"chisel-v2", in which ``public-keys`` (top-level) and
``archive.<name>.public-keys`` fields are introduced. This changes is
related to the addition of integrity checks in chisel. [1]
[1] canonical/chisel#106
|
Don't merge before the 9th (requested by MSFT) |
cjdcordeiro
left a comment
There was a problem hiding this comment.
See my comment in canonical/chisel#106 (review)
I don't think we should bump to chisel-v2 just yet. Chisel v0.8.1 will be able to cope with these public-keys for a while longer
as a note, we've agreed to later bump the format to just |
|
Due to recent developments, the format has been reverted to the previous version |
cjdcordeiro
left a comment
There was a problem hiding this comment.
As per recent discussions, we'll need to change public-keys to v1-public-keys (this applies to the other significant ones.
Then we can merge it for testing with canonical/chisel#106.
Before merging, we need to ensure v0.8.1 works with it
letFunny
left a comment
There was a problem hiding this comment.
Because we do not have a CI please test it locally as well to make sure. I did:
| v0.8.1 | canonical/chisel#106 |
|---|---|
| ✓ | ✓ |
cjdcordeiro
left a comment
There was a problem hiding this comment.
looking good now. thanks for the changes
This PR adds the Ubuntu Archive Automatic Signing Key (2018) as a "public-key" in the chisel.yaml. The armored data was obtained by executing the following commands on a Ubuntu 22.04 machine:
BREAKING CHANGE: This PR introduces the new chisel yaml format "chisel-v2", in which
public-keys(top-level) andarchive.<name>.public-keysfields are introduced. This change is related to the addition of integrity checks in chisel. [1][1] canonical/chisel#106