feat: add support for v2 format#197
Conversation
letFunny
commented
Jan 24, 2025
- Have you signed the CLA?
* feat: add support for format v2 --------- Co-authored-by: Alberto Carretero <alberto.carretero@canonical.com>
niemeyer
left a comment
There was a problem hiding this comment.
This looks all good, thank you.
Do we want to do anything else before we merge the PR and brand the code as v2?
Any other pending transitions?
|
@niemeyer The idea is to introduce the first version with |
|
@letFunny Sounds good. I'm marking this issue as done on my end for the time being. Please ping me when it's time. |
|
Discussed with Cris offline and this is ready for review. |
|
niemeyer
left a comment
There was a problem hiding this comment.
Code seems mechanically fine, but let's please check status with Chris as it's been a while since we discussed the v2 updates.
cjdcordeiro
left a comment
There was a problem hiding this comment.
LGTM. The ubuntu-25.04 chisel-release has been opened with v1, and ubuntu-2*.04 (LTS) chisel-releases are currently using the v2-archives field for the Pro archives (also under the v1 format).
After merging this PR:
- I'll release Chisel v1.2.0
- open chisel-release
ubuntu-25.10withv2 v2-archivesis already removed fromv2in this PR, so we're good there