Skip to content

fix: info supports "generate" paths#163

Merged
niemeyer merged 1 commit intocanonical:mainfrom
rebornplusplus:fix/info-support-generate
Oct 7, 2024
Merged

fix: info supports "generate" paths#163
niemeyer merged 1 commit intocanonical:mainfrom
rebornplusplus:fix/info-support-generate

Conversation

@rebornplusplus
Copy link

Currently, the info command does not support the "generate" keyword in paths. This is a bug.

$ chisel info --release ubuntu-24.04 base-files_chisel
2024/10/07 08:47:57 Consulting release repository...
2024/10/07 08:47:57 Cached ubuntu-24.04 release is still up-to-date.
2024/10/07 08:47:57 Processing ubuntu-24.04 release...
error: internal error: unrecognised PathInfo type: generate

This PR fixes the said bug and adds support for "generate"-kind paths in the info command.

Currently the info command does not support the "generate" keyword in
paths. This is a bug.

    $ chisel info --release ubuntu-24.04 base-files_chisel
    2024/10/07 08:47:57 Consulting release repository...
    2024/10/07 08:47:57 Cached ubuntu-24.04 release is still up-to-date.
    2024/10/07 08:47:57 Processing ubuntu-24.04 release...
    error: internal error: unrecognised PathInfo type: generate

This commit fixes the said bug and adds support for "generate"-kind
paths in the info command.
Copy link
Collaborator

@letFunny letFunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Rafid for finding this!

@letFunny letFunny added Priority Look at me first Bug An undesired feature ;-) labels Oct 7, 2024
@cjdcordeiro cjdcordeiro added the Simple Nice for a quick look on a minute or two label Oct 7, 2024
@cjdcordeiro cjdcordeiro requested a review from niemeyer October 7, 2024 09:54
Copy link
Contributor

@niemeyer niemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks indeed 👍

@niemeyer niemeyer merged commit 302ec57 into canonical:main Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug An undesired feature ;-) Priority Look at me first Simple Nice for a quick look on a minute or two

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants