bugfix: ignore extra fields in yaml#107
Merged
niemeyer merged 2 commits intocanonical:mainfrom Dec 13, 2023
Merged
Conversation
Ignoring extra fields makes the code forward compatible with changes in the yaml format, without a version bump being necessary.
rebornplusplus
approved these changes
Dec 13, 2023
| type yamlRelease struct { | ||
| Format string `yaml:"format"` | ||
| Archives map[string]yamlArchive `yaml:"archives` | ||
| Archives map[string]yamlArchive `yaml:"archives"` |
cjdcordeiro
approved these changes
Dec 13, 2023
Collaborator
cjdcordeiro
left a comment
There was a problem hiding this comment.
Nice. This also propagates to PathInfo right? (e.g. /path: {badkind: foo})
Collaborator
Author
|
@cjdcordeiro You are absolutely right, I have added another field in the test to reflect that. |
Collaborator
A bit too late, but also not too urgent: @letFunny if you add a new key under |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignoring extra fields makes the code forward compatible with changes in the yaml format, without a version bump being necessary.