1719725: cockpit - Don't concurrently set config and attach#2116
Closed
mvollmer wants to merge 1 commit intocandlepin:masterfrom
Closed
1719725: cockpit - Don't concurrently set config and attach#2116mvollmer wants to merge 1 commit intocandlepin:masterfrom
mvollmer wants to merge 1 commit intocandlepin:masterfrom
Conversation
|
Can one of the admins verify this patch? |
Contributor
Author
|
This can be seen as a workaround for a bug in rhsmd, but I haven't tried to find that bug yet. |
Previously, the code would fire off all the Config.Set calls plus the Attach.AutoAttach call one after the other without waiting for their replies. The daemon can't seem to cope with this and corrupts the config file as a result. Thus, the calls are now done strictly sequentially. Also, restart rhsm service after changing config values. This seems to be necessary.
635e220 to
ee7e300
Compare
Contributor
Author
I have started looking, so we might want to put this PR on hold for a bit longer. |
Contributor
I agree. I would like to fix the bug in rhsm daemon properly, because the daemon should handle such situation without corrupting rhsm.conf. I wonder why auto-attach changes rhsm.conf? |
Contributor
Author
I think I got it: #2120 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the code would fire off all the Config.Set calls plus the
Attach.AutoAttach call one after the other without waiting for their
replies. The daemon can't seem to cope with this and corrupts the
config file as a result.
Thus, the calls are now done strictly sequentially.
Also, restart rhsm service after changing config values. This seems
to be necessary.